Fix Hermes plugin rollback safety - #26
Open
vxcozy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
v0.3.3 fixed active-profile selection, but recovery could still make a failed setup worse. Louder Bridge could remove the new plugin before the previous copy was safely back in place, or leave Hermes enabled after deleting its files. Recovery now keeps the last complete owned plugin directory and restores the matching config. If either side cannot be verified, it fails without deleting the working copy.
Uninstall also stops editing plugin arrays by numeric index. It calls
hermes plugins disable louder-bridge, leaves the expected disabled entry, and lets reinstall clear it through the normal enable path. That protects unrelated plugins when their list order changes.Hermes Agent 0.19.0 still performs
plugins disableas a non-atomic read/modify/write. A separate config write that lands inside that command can still be overwritten. Removing that last race requires an atomic remove-by-value or compare-and-swap operation in Hermes itself.Checks
npm test(391 tests passed).npm run authorship:check.npm run security:check.npm run release:check./humanizeron documentation, release notes, app text, CLI output, and other public writing changed by this pull request.Compatibility
Verified on macOS 26.6.1 with Node.js 22.23.1, Hermes Agent 0.19.0, and Louder Bridge 0.3.3 source. The regression suite uses isolated temporary Hermes homes and covers install, update, uninstall, concurrent config edits, and failed filesystem recovery.
No physical Codex Micro run was needed because this change does not touch device input, firmware, connection handling, MIC behavior, or terminal integration. Existing Hermes profiles and the installed app were not used or modified.
Post-deploy validation
On the first install, update, and uninstall with Hermes 0.19:
plugins.enabledandplugins.disabledentries stay unchanged.louder-bridgedisabled and reinstall clears that entry.could not be fully rolled back,configuration changed during setup,managed Hermes plugin is missing, andsettings changed during rollback.Stop rollout and revert this change if an unrelated plugin entry changes or Hermes points at a missing managed plugin. The maintainer owns this check through the first full install/update/uninstall cycle after merge. This local setup path has no separate runtime dashboard.