Add unit tests for ppo_continuous_action GAE computation - #560
Open
YangNuoCheng wants to merge 2 commits into
Open
Add unit tests for ppo_continuous_action GAE computation#560YangNuoCheng wants to merge 2 commits into
YangNuoCheng wants to merge 2 commits into
Conversation
|
@YangNuoCheng is attempting to deploy a commit to the Costa Huang's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Towards #252, and a follow-up to the GAE unit tests for
ppo.py. Adds logic unit tests for the GAE computation incleanrl/ppo_continuous_action.py.test_ppo_continuous_action_gae_matches_explicit_sum— cross-checks the reverse in-place recurrence inppo_continuous_action.pyagainst an independent explicit discounted-sum referenceA_t = Σ_{k≥t} (γλ·nnt)^… · δ_k, on randomized rollouts (with terminations). Same precedent astests/test_jax_compute_gae.py.test_ppo_continuous_action_gae_terminal_masking— a hand-computed example that specifically exercises the episode-termination masking path: adonemust zero outnextnonterminaland stop advantage propagation across the boundary. Expected advantages[1.25, 1.0, 1.0]are reviewer-verifiable by hand.This targets the issue's goal of verifying logic correctness rather than black-box outputs, and the terminal-masking case adds coverage for the boundary behavior that is easy to break silently.
Types of changes
Checklist
pytest tests/test_ppo_continuous_action_gae.py(2 passed)--line-length=127, isort--profile=black)