Skip to content

Add doc for stylelint - #1343

Merged
yyx990803 merged 3 commits into
vuejs:masterfrom
gucong3000:stylelint
Jul 3, 2018
Merged

Add doc for stylelint#1343
yyx990803 merged 3 commits into
vuejs:masterfrom
gucong3000:stylelint

Conversation

@gucong3000

@gucong3000 gucong3000 commented Jun 12, 2018

Copy link
Copy Markdown

Related: #303

  • en
  • zh
  • ru

@gucong3000

Copy link
Copy Markdown
Author

@yyx990803
If you like this PR, I will find someone to help translate it to Russian.

@gucong3000

Copy link
Copy Markdown
Author

Anyone make any comments?

@kazupon

kazupon commented Jul 3, 2018

Copy link
Copy Markdown
Member

/ping @Alex-Sokolov
Can you help translation about it?

@gucong3000

Copy link
Copy Markdown
Author

Does anyone have any comments on the Chinese and English parts?

@kazupon

kazupon commented Jul 3, 2018

Copy link
Copy Markdown
Member

On second thought 馃, I think that we don't have to put it to Vue Loader documentation, because stylelint is not necessarily required linter and it optional set with user.

@Alex-Sokolov

Copy link
Copy Markdown

@kazupon done (gucong3000#1), needed merge from @gucong3000

P.S.: Can you merge #1342

@gucong3000

gucong3000 commented Jul 3, 2018

Copy link
Copy Markdown
Author

stylelint is not necessarily required linter

I don't quite understand why the linter of CSS code is less important than JS?
CSS code is as important to a project as JS, so they also need linter

@gucong3000 gucong3000 changed the title [WIP] Add doc for stylelint Add doc for stylelint Jul 3, 2018
@gucong3000

Copy link
Copy Markdown
Author

Stylelint is used by Facebook, Wikipedia and GitHub.

create-react-app will support it.

Right now it is the most popular CSS linter.

@kazupon

kazupon commented Jul 3, 2018

Copy link
Copy Markdown
Member

@gucong3000
Yeah, Linter of CSS codes is very important.
However, I think should not include how to setting of Stylelint, due to already exist as Stylelint documentation.
https://github.com/webpack-contrib/stylelint-webpack-plugin

@gucong3000

Copy link
Copy Markdown
Author

due to already exist as Stylelint documentation.
https://github.com/webpack-contrib/stylelint-webpack-plugin

It does not contain *.vue file configuration.

@yyx990803

yyx990803 commented Jul 3, 2018

Copy link
Copy Markdown
Member

I think this is good to have. Thanks!

@kazupon I think it's nice to provide related information as people may not realize stylelint already works with Vue files.

@yyx990803
yyx990803 merged commit 791999a into vuejs:master Jul 3, 2018
@kazupon

kazupon commented Jul 3, 2018

Copy link
Copy Markdown
Member

@yyx990803
okay! I got it!

@gucong3000
gucong3000 deleted the stylelint branch July 4, 2018 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants