Skip to content

Increase timeout config to reduce timeout errors in large carts #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mecrano wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Increase timeout config to reduce timeout errors in large carts #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c24571
perf: increase timeout config to reduce timeout errors in large carts
Apr 25, 2024
32ff79c
update changelog
Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Increase timeout

## [0.67.0] - 2024-02-27

### Added
Expand Down
4 changes: 2 additions & 2 deletions node/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { schemaDirectives } from './directives'
import { resolvers } from './resolvers'

const THREE_SECONDS_MS = 3 * 1000
const TEN_SECONDS_MS = 10 * 1000
const FORTY_FIVE_SECONDS_MS = 45 * 1000

// Segments are small and immutable.
const MAX_SEGMENT_CACHE = 10000
Expand All @@ -20,7 +20,7 @@ export default new Service<Clients, RecorderState, CustomContext>({
implementation: Clients,
options: {
checkout: {
timeout: TEN_SECONDS_MS,
timeout: FORTY_FIVE_SECONDS_MS,
},
default: {
retries: 2,
Expand Down
4 changes: 2 additions & 2 deletions node/service.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"stack": "nodejs",
"memory": 258,
"ttl": 43200,
"timeout": 30,
"minReplicas": 2,
"timeout": 45,
"minReplicas": 4,
"maxReplicas": 120,
"workers": 4,
"cpu": 30
Expand Down