Fix quotes with unit multiplier - #83
Closed
nicholas-maestrello wants to merge 2 commits into
Closed
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
This PR fixes critical pricing issues in the B2B Quotes GraphQL backend when applying quotes to shopping carts:
1. Index-Based Mapping Bug (Price Mismatch)
Problem: When a quote contained multiple lines of the same SKU at different prices, the
useQuotemutation was using a simple index-based mapping that didn't account for VTEX's automatic item grouping. This caused:Example:
2. Currency Precision (ORD024 Error)
Problem: VTEX's OrderForm API rejects prices that don't match the currency's decimal precision. For currencies like CLP and JPY that have 0 decimal places, prices must be multiples of 100.
Error:
3. Gift Item Errors
Problem: The mutation attempted to apply manual prices to gift items, which is forbidden by VTEX's checkout API.
4. UnitMultiplier in Subtotals
Problem: Quote subtotal calculations weren't applying
unitMultiplier, causing mismatches between displayed quote totals and actual cart totals for items sold by weight, volume, or other measurements.How to test it?
Test 1: Weighted Average Pricing
Test 2: CLP Currency Handling
Test 3: USD/BRL Currency Handling
Test 4: Gift Items
Test 5: UnitMultiplier
unitMultiplier != 1(e.g., products sold by kg)Screenshots or example usage
Screen.Recording.2026-02-19.at.13.19.47.mov
Related to / Depends on