Skip to content

ClickHouse: Complete driver support - #1314

Merged
vrana merged 1 commit into
vrana:mainfrom
bpbp-boop:clickhouse-driver
Aug 4, 2026
Merged

ClickHouse: Complete driver support#1314
vrana merged 1 commit into
vrana:mainfrom
bpbp-boop:clickhouse-driver

Conversation

@bpbp-boop

Copy link
Copy Markdown
Contributor

Codex assisted

@vrana

vrana commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Have you extensively tested this with a real ClickHouse instance? Have you read and understood all the generated code?

@vrana vrana added the Waiting label Aug 3, 2026
@bpbp-boop

bpbp-boop commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Yes, we've been using it in-house for a few weeks. The code is quite mechanical, just filling in the functions adminer expects so it works. The main weakness is the lack of index editing or ability to set the primary key during table creation.

edit: to support primary keys properly for clickhouse (multi column, no auto-increment) would have required bigger changes in Adminer. wasn't sure how far to go with this PR. for our use case reading/editing/exporting data with this driver was enough.

@vrana vrana removed the Waiting label Aug 4, 2026
@vrana
vrana merged commit a38ddd1 into vrana:main Aug 4, 2026
1 check passed
@vrana

vrana commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Thanks for your contribution. There were some regressions so I've fixed them together with some smaller issues in 9ba86b4. Please test it against Git Adminer (6.0.0-dev in the main branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants