Improve Composer-based developer workflow and fix PHPCS/PHPStan issues - #1296
Closed
Marcus-Nightingale wants to merge 10 commits into
Closed
Improve Composer-based developer workflow and fix PHPCS/PHPStan issues#1296Marcus-Nightingale wants to merge 10 commits into
Marcus-Nightingale wants to merge 10 commits into
Conversation
* ran phpcs auto fix to correct violations, * added make commands from phpcs
Owner
|
I'm not interested in adding the empty lines everywhere. |
Contributor
Author
|
No worries i will take this out and add in the rule to exclude the warning 👍🏻 is there anything else in terms of the code styling you don't like etc? |
Owner
|
I want to keep everything as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the project’s Composer workflow so developers can run checks more easily and CI uses the same entry points.
Main changes:
• Added Composer scripts for phpcs, phpcbf, and phpstan
• Added fallback behavior so the coding tools can run from vendor/bin, a global Composer install, or PATH
• Updated CI to run composer phpcs and composer phpstan directly
• Fixed the PHPStan config and resolved the PHPStan issues reported on this branch
• Fixed the PHPCS issues reported on this branch
• Updated the README with the Composer-based coding standard commands
• Confirmed composer compile still works
Validation:
• composer phpcs
• composer phpstan
• composer compile