Skip to content

Fix QuickDevBar tab activation against missing pane bindings - #104

Open
alexzt wants to merge 1 commit into
vpietri:mainfrom
alexzt:bugfix/quickdevbar-load
Open

Fix QuickDevBar tab activation against missing pane bindings#104
alexzt wants to merge 1 commit into
vpietri:mainfrom
alexzt:bugfix/quickdevbar-load

Conversation

@alexzt

@alexzt alexzt commented Aug 16, 2026

Copy link
Copy Markdown

Summary

Fix ADM_QuickDevBar tab initialization on the storefront custom theme. The toolbar loads correctly in the admin theme, but on the storefront custom theme the tab markup/pane wiring can be incomplete or
mismatched, which caused tab activation to fail.

What changed

  • Scope pane lookup to the same .qdb-container as the tab list.
  • Skip tab groups that have no matching pane container.
  • Skip individual tabs that do not have a paired pane.
  • Guard toggle()/resetForTab() against missing active tabs or panes.
  • Make isActiveTab() null-safe.

Why

On the storefront custom theme, the QuickDevBar tab script could fail with:

  • tab is undefined
  • pane is undefined

That prevented the tab content from appearing even though the active tab state changed.

On the admin theme, the same component loads normally, so this is a storefront/theme-specific markup matching issue rather than a general QuickDevBar failure.

Verification

  • node --check view/base/web/js/tabbis.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant