Release 5.0.0 - #188
Merged
Merged
Conversation
Member
Author
|
I would like to include #189 as well |
bastelfreak
force-pushed
the
rel500
branch
3 times, most recently
from
June 26, 2024 20:20
3074366 to
c2141d9
Compare
ekohl
requested changes
Jun 27, 2024
ekohl
left a comment
Member
There was a problem hiding this comment.
This suggestion assumes #189 is merged, but I'm a bit hesitant on that. I'd prefer to formally deprecate it first.
That means:
- Make sure the configuration option to switch is well documented
- Migration guide
- Announce the next major version will drop it
- Communicate this (also to PDK users)
bastelfreak
force-pushed
the
rel500
branch
2 times, most recently
from
June 28, 2024 16:50
8684758 to
60e902c
Compare
Member
Author
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 94.93% 95.06% +0.12%
==========================================
Files 2 2
Lines 158 162 +4
==========================================
+ Hits 150 154 +4
Misses 8 8 ☔ View full report in Codecov by Sentry. |
bastelfreak
force-pushed
the
rel500
branch
2 times, most recently
from
June 28, 2024 17:11
0b2587d to
a0ac683
Compare
rwaffen
approved these changes
Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.