Add cloud hash to provide id and auth for cloud elastisearch - #43
Open
Luckless wants to merge 1 commit into
Open
Add cloud hash to provide id and auth for cloud elastisearch#43Luckless wants to merge 1 commit into
cloud hash to provide id and auth for cloud elastisearch#43Luckless wants to merge 1 commit into
Conversation
igalic
reviewed
Sep 5, 2020
| 'metrics' => $winlogbeat::metrics, | ||
| 'event_logs' => $winlogbeat::event_logs_final, | ||
| }, | ||
| 'cloud' => $winlogbeat::cloud, |
There was a problem hiding this comment.
I'm not seeing this section in the template
or do we have general treatment for that?
There was a problem hiding this comment.
either way, having a test that proves this code correct would be useful.
Author
There was a problem hiding this comment.
I see what you mean. Adding the erb template changes to set a cloud.id and cloud.auth and will get it working with my elastic.co version today
Author
|
Yep, I'll be trying this out next week on some of my windows servers. It's
in the config file documentation so I'm optimistic
…On Sat, Sep 5, 2020, 4:26 AM Mina Galić (deprecated: Igor Galić) < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In manifests/config.pp
<#43 (comment)>
:
> @@ -11,6 +11,7 @@
'metrics' => $winlogbeat::metrics,
'event_logs' => $winlogbeat::event_logs_final,
},
+ 'cloud' => $winlogbeat::cloud,
either way, having a test that proves this code correct would be useful.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#43 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5AV3UG5Q4CBAZCEDENBKTSEHY4JANCNFSM4QZEGPRA>
.
|
Luckless
force-pushed
the
master
branch
2 times, most recently
from
September 8, 2020 18:22
1c521d5 to
3ebe7c7
Compare
…ch compatibility Resolves voxpupuli#42
igalic
suggested changes
Sep 8, 2020
igalic
left a comment
igalic
left a comment
There was a problem hiding this comment.
if we can get some spec tests for this, it'll be perfect
Author
|
Still working through some issues on my end needing proxy and cors so I
need to get my local testing done first.
Ill try to get a positive and negative spec test put in place later this
week
I do think the change is functional now since I get back cors http 403
forbiddens
More to come later this week :)
…On Tue, Sep 8, 2020, 4:24 PM Mina Galić ***@***.***> wrote:
***@***.**** requested changes on this pull request.
if we can get some spec tests for this, it'll be perfect
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#43 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5AV3X4GVCPZJT6V2KMBC3SE2HJPANCNFSM4QZEGPRA>
.
|
Author
|
I know this has been opened a long time but we went away from elastic cloud and now we are coming back I'm at a bit of a loss how to write spec tests to get this accepted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Adds
cloudhash for providingidandauthfor cloud elastisearch compatibilityThis Pull Request (PR) fixes the following issues
Fixes #42