This repository was archived by the owner on Nov 5, 2024. It is now read-only.
puppet-lint: fix top_scope_facts warnings - #201
Open
bastelfreak wants to merge 1 commit into
Open
Conversation
ekohl
reviewed
Aug 30, 2021
| ) { | ||
| if $::stash_version { | ||
| if versioncmp($::stash_version, '3.2') < 0 { | ||
| if $facts['stash_version'] { |
Member
There was a problem hiding this comment.
With strict variables, does this work if the fact is not defined? Should it use
Suggested change
| if $facts['stash_version'] { | |
| if fact('stash_version') { |
Same goes for the other file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues