This repository was archived by the owner on Nov 5, 2024. It is now read-only.
modulesync 4.0.0 - #197
Open
bastelfreak wants to merge 22 commits into
Open
Conversation
ekohl
suggested changes
Nov 25, 2020
ekohl
left a comment
ekohl
left a comment
Member
There was a problem hiding this comment.
Acceptance tests need to use voxpupuli-acceptance to work. However, I think stash is actually bitbucket nowadays. Not sure if it really still works. Previously no acceptance tests ran at all.
Member
|
At least updated to use voxpupuli-acceptance but no idea how well it'll work. Looks like this also does things with hiera in acceptance tests so I think that's been long broken. |
ekohl
suggested changes
Nov 25, 2020
ekohl
left a comment
ekohl
left a comment
Member
There was a problem hiding this comment.
At least EL7 is failing on the JDK:
Error: Execution of '/opt/puppetlabs/puppet/bin/curl http://download.oracle.com/otn-pub/java/jdk/8u45-b14/jdk-8u45-linux-x64.tar.gz -o /tmp/jdk-8u45-linux-x64.tar.gz_20201125-739-1crfp4t -fsSLg --max-redirs 5 --cookie oraclelicense=accept-securebackup-cookie' returned 22: curl: (22) The requested URL returned error: 404 Not Found
Didn't bother to look at the other acceptance tests, but they need work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modulesync 4.0.0