Skip to content
This repository was archived by the owner on Nov 5, 2024. It is now read-only.

Fix Dockerfile - #193

Open
fixdocker wants to merge 1 commit into
voxpupuli:masterfrom
fixdocker:master
Open

Fix Dockerfile#193
fixdocker wants to merge 1 commit into
voxpupuli:masterfrom
fixdocker:master

Conversation

@fixdocker

Copy link
Copy Markdown

Pull Request (PR) description

Hello, I represent a research group investigating build failures in
Dockerfiles. We executed a Dockerfile in your project and found that
it is not building. We are sending this Pull Request with a suggested
repair. The repair operation is based the following URL contextualized to this case:

Please note that we are using an anonymous GitHub account because of
double-blind restrictions in the submission process of conferences.

This Pull Request (PR) fixes the following issues

@fixdocker

Copy link
Copy Markdown
Author

Hey @bastelfreak @dickp , can you check this PR?

@bastelfreak

Copy link
Copy Markdown
Member

Hello,
please see the full thread here: https://twitter.com/BastelsBlog/status/1295395255383207937
I don't think that this fix is the correct approach. Instead the base image should be updated to the correct ruby one. Also our dockerfile, where you send us multiple PRs, comes from a central place: https://github.com/voxpupuli/modulesync_config/blob/master/moduleroot/Dockerfile.erb
Please do not provide patches for our 125 other identical dockerfiles

@fixdocker

fixdocker commented Aug 20, 2020

Copy link
Copy Markdown
Author

hello @bastelfreak, we apologize for any problems that this and the other
pull requests have caused, our intention is just to help.

What do you think of us sending a single PR to the central
place, just updating the version of the base image to 2.5.8
as mentioned in the twitter thread?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants