Skip to content

add support for Sensitive type in Environment - #98

Merged
traylenator merged 1 commit into
voxpupuli:masterfrom
gmenuel:sensitive
Mar 24, 2026
Merged

add support for Sensitive type in Environment#98
traylenator merged 1 commit into
voxpupuli:masterfrom
gmenuel:sensitive

Conversation

@gmenuel

@gmenuel gmenuel commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

Pull Request (PR) description

Sometimes it is useful to set an environment variable containing sensitive information. This PR add the support for the Sensitive type in the Environment field of the container block.

This Pull Request (PR) fixes the following issues

n/a

@traylenator

Copy link
Copy Markdown
Collaborator

Isn't #94 the correct thing to do here really.
Set secret as a podman secret and it will magically appear inside the container as an Environment.

@gmenuel

gmenuel commented Feb 17, 2026

Copy link
Copy Markdown
Contributor Author

Yes using podman secret is probably cleaner, this is just easier to use, and since it was really not complicated to implement I thought it could be useful (it is at least for me 🙂)

@traylenator

traylenator commented Feb 17, 2026 via email

Copy link
Copy Markdown
Collaborator

@traylenator

Copy link
Copy Markdown
Collaborator

Hi,

Could you add a new acceptance test case for this. Just to confirm nothing blows up later in the templates or something.

Otherwise fine.

@gmenuel

gmenuel commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

I've added an acceptance spec, I'm not 100% sure that I've done everything that is needed to have the test run, don't hesitate if something is missing or wrong.
And now the acceptance tests are failing but I think this as nothing to do with my PR.

@traylenator

Copy link
Copy Markdown
Collaborator

The unrelated test failure is now fixed if you want to take another look.

@traylenator
traylenator merged commit a508614 into voxpupuli:master Mar 24, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants