Permit build type, add missing quadlet arguments - #103
Merged
Conversation
Container: add AppArmor, HttpProxy, LogOpt, HealthStartupRetries, HealthStartupSuccess, RetryDelay, SecurityLabelLevel, SecurityLabelType; fix PidsLimits -> PidsLimit (matches quadlet man page spelling). Pod: add AddHost, DNS, DNSOption, DNSSearch, ExitPolicy, GIDMap, IP, IP6, NetworkAlias, ServiceName, ShmSize, StopTimeout, SubGIDMap, SubUIDMap, UIDMap. Spec: expand type alias tests to cover every defined key across Container, Pod, Kube, Network, Volume, and Image unit types.
Add Quadlets::Unit::Build type alias covering all 27 options documented in the podman-systemd.unit(5) man page: Annotation, Arch, AuthFile, BuildArg, ContainersConfModule, DNS, DNSOption, DNSSearch, Environment, File, ForceRM, GlobalArgs, GroupAdd, IgnoreFile, ImageTag, Label, Network, PodmanArgs, Pull, Retry, RetryDelay, Secret, SetWorkingDirectory, Target, TLSVerify, Variant, Volume. Wire the new type into quadlets::quadlet as build_entry, add Build to the template section list, extend Quadlets::Quadlet_name to accept .build files, and add spec coverage for the type alias, the define, and the name pattern. Update README with a build-then-run example.
traylenator
reviewed
Apr 21, 2026
traylenator
reviewed
Apr 22, 2026
Collaborator
|
Like what you did with the sanity checks - much cleaner and simpler. |
Replace seven parallel if/or chains with a hash that maps each quadlet type to its one permitted section entry. A single filter pass over all entry names finds any unexpected non-undef values and fails with a descriptive message naming the offending entries. Adding a new quadlet type now requires one line in $_type_entry_map and one line in $_all_entries rather than touching every existing case branch.
traylenator
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This adds in a few of the missing podman arguments, fixes a typo, and adds the build type of quadlet.
This Pull Request (PR) fixes the following issues