Skip to content

Update metadata.json (project information, PDK) - #15

Closed
LirionOSS wants to merge 1 commit into
voxpupuli:mainfrom
LirionOSS:qa_pdk_update
Closed

Update metadata.json (project information, PDK)#15
LirionOSS wants to merge 1 commit into
voxpupuli:mainfrom
LirionOSS:qa_pdk_update

Conversation

@LirionOSS

@LirionOSS LirionOSS commented Mar 26, 2025

Copy link
Copy Markdown
Contributor

metadata.json had outdated information:

  • The project's new home is Vox Pupuli now
  • Dropping PDK information

Comment thread metadata.json Outdated
Comment on lines +114 to +116
"pdk-version": "3.4.0",
"template-url": "pdk-default#3.4.0",
"template-ref": "tags/3.4.0-0-gd3cc13f"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vox pupuli doesn't use pdk, please remove the elements

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those have been present after migration, so instead we can use this PR to indeed remove them. Will do so later.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Comment thread metadata.json Outdated
"operatingsystemrelease": [
"7",
"8"
"8",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for adding and removing operating systems, we prefer dedicated pull requests. our changelog is autogenerated based on pull requests. adding a new operating system is an enhancement, removing one is a breaking change. Those are different sections in the CHANGELOG, so we need separate PRs for it.

@LirionOSS LirionOSS Mar 28, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure on how many PRs to create, I chose "too few". Will remove the OS change from this PR later.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Comment thread metadata.json Outdated
"version_requirement": ">= 6.6.0 < 8.0.0"
},
{
"name": "puppet/extlib",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the module already use extlib?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be done together with another PR requiring extlib if still required. Removed.

- The project's new home is Vox Pupuli now
- Dropping PDK information
@LirionOSS

Copy link
Copy Markdown
Contributor Author

@bastelfreak I believe now we have a clean commit fixing all points in question. Force-pushed a clean version.

@LirionOSS LirionOSS changed the title Update PDK refs, update metadata.json, update .fixtures.yml Update metadata.json (project information, PDK) Oct 1, 2025
@LirionOSS

Copy link
Copy Markdown
Contributor Author

The subject of this PR still carries stuff we don't need anymore, and it'S dated.

Closing. I guess fixing the module name in metadata.json should come from a clean PR.

@LirionOSS LirionOSS closed this Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants