Beaker acceptance test : add idempotency check - #225
Conversation
Dan33l
changed the title
b4f61bf to
34172f7
Compare
* add idempotency check * rework because fail2ban::config and fail2ban::service are privates * renaming accordingly with name of tested class
Dan33l
changed the title
jhoblitt
left a comment
jhoblitt
left a comment
There was a problem hiding this comment.
I'm OK with in-lining the manifest instead of using an example file although I do generally prefer using examples. The outdenting is kind of odd and should be fixed.
| it_behaves_like 'an idempotent resource' do | ||
| let(:manifest) do | ||
| <<-EOS | ||
| class { 'fail2ban': } |
There was a problem hiding this comment.
This should be indented instead of outdented. I'm surprised that rubocop didn't warn on this...
| it_behaves_like 'an idempotent resource' do | ||
| let(:manifest) do | ||
| <<-EOS | ||
| class { 'fail2ban': |
There was a problem hiding this comment.
Same issue with outdenting. This would also be better as an example/*.pp so that it is linted.
| it_behaves_like 'an idempotent resource' do | ||
| let(:manifest) do | ||
| <<-EOS | ||
| $_config_file_template = $facts['os']['family'] ? { |
There was a problem hiding this comment.
Same issue with outdenting. This would also be better as an example/*.pp so that it is linted.
| it_behaves_like 'an idempotent resource' do | ||
| let(:manifest) do | ||
| <<-EOS | ||
| $_config_file_template = $facts['os']['family'] ? { |
There was a problem hiding this comment.
Same issue with outdenting. This would also be better as an example/*.pp so that it is linted.
| it_behaves_like 'an idempotent resource' do | ||
| let(:manifest) do | ||
| <<-EOS | ||
| $_config_file_template = $facts['os']['family'] ? { |
There was a problem hiding this comment.
Same issue with outdenting. This would also be better as an example/*.pp so that it is linted.
| it_behaves_like 'an idempotent resource' do | ||
| let(:manifest) do | ||
| <<-EOS | ||
| $_config_file_template = $facts['os']['family'] ? { |
There was a problem hiding this comment.
Same issue with outdenting. This would also be better as an example/*.pp so that it is linted.
| it_behaves_like 'an idempotent resource' do | ||
| let(:manifest) do | ||
| <<-EOS | ||
| class { 'fail2ban': |
There was a problem hiding this comment.
Same issue with outdenting. This would also be better as an example/*.pp so that it is linted.
| it_behaves_like 'an idempotent resource' do | ||
| let(:manifest) do | ||
| <<-EOS | ||
| class { 'fail2ban': |
There was a problem hiding this comment.
Same issue with outdenting. This would also be better as an example/*.pp so that it is linted.
4 participants
This PR also:
fail2ban::configandfail2ban::serviceare privatesPull Request (PR) description
This Pull Request (PR) fixes the following issues