WIP: Add support for package install options - #164
Open
yorickps wants to merge 1 commit into
Open
Conversation
kenyon
reviewed
Aug 4, 2021
yorickps
force-pushed
the
install_options
branch
from
August 4, 2021 17:48
e825859 to
60106ec
Compare
Author
|
@kenyon thanks for the review, fixed the accidental mistake. |
yorickps
force-pushed
the
install_options
branch
from
August 4, 2021 20:15
60106ec to
ebfdbfa
Compare
kenyon
previously requested changes
Aug 4, 2021
kenyon
left a comment
kenyon
left a comment
Member
There was a problem hiding this comment.
Can you also add a test that uses this new parameter? https://github.com/voxpupuli/puppet-fail2ban/blob/master/spec/classes/init_spec.rb
Thanks!
yorickps
force-pushed
the
install_options
branch
2 times, most recently
from
August 5, 2021 16:03
fa27150 to
5b5527f
Compare
kenyon
self-requested a review
August 5, 2021 17:59
yorickps
changed the title
See puppet package resource for more info <https://puppet.com/docs/puppet/7/types/package.html#package-attribute-install_options> Better define type Set to undef Add spec test for package_install_options
yorickps
force-pushed
the
install_options
branch
from
August 5, 2021 19:52
5b5527f to
58eb9ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add support for package install options.
See puppet package resource for more info:
https://puppet.com/docs/puppet/7/types/package.html#package-attribute-install_options