Skip to content

add server parameter on collectd::plugin::network::server - #995

Open
fe80 wants to merge 1 commit into
voxpupuli:masterfrom
fe80:multiple_server
Open

add server parameter on collectd::plugin::network::server#995
fe80 wants to merge 1 commit into
voxpupuli:masterfrom
fe80:multiple_server

Conversation

@fe80

@fe80 fe80 commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

Hello,

I've actually a profile class with a Collectd::Plugin::Network::Server. My collectd can be overwrite by anybody, and my profil class can't be detect which old network file it's require to clean if I not create a new resource with absent statement.

I would like to manage this plugin with a fixed file name and define the server with a separated parameter.

Pull Request (PR) description

This feature include the possibility to add a specific title on collectd::plugin::network::server for the configuration file name. The server should be define with the server option.

This Pull Request (PR) fixes the following issues

Comment thread spec/defines/collectd_plugin_network_server_spec.rb Outdated
Comment thread manifests/plugin/network/server.pp Outdated
Comment thread spec/defines/collectd_plugin_network_server_spec.rb Outdated
Comment thread spec/defines/collectd_plugin_network_server_spec.rb Outdated
This feature include the possibility to add a specific title on
`collectd::plugin::network::server` for the configuration file name. The
server should be define with the `server` option.
@fe80
fe80 force-pushed the multiple_server branch from bec06c0 to 4943084 Compare March 28, 2022 21:09

@smortex smortex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smortex smortex added the enhancement New feature or request label Mar 28, 2022
@traylenator

Copy link
Copy Markdown
Contributor

Hi

Could you rebase this. Arch support has been removed so that faling test will no longer exist.

Adding a needs-rebase tag, please remove once done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request needs-rebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants