[#17] Added the configuration parameter 'use-short-cache-path'. - #63
Open
renkin wants to merge 1 commit into
Open
[#17] Added the configuration parameter 'use-short-cache-path'.#63renkin wants to merge 1 commit into
renkin wants to merge 1 commit into
Conversation
Additionally to the configuration parameter 'tmp', this parameter is helpful to avoid too long cache paths under Windows. This is achieved by shortening the cache path part of the Puppet forge URI to the 7 first digits of its SHA1 checksum (like short Git commit hash approach). Under Windows this shortening is especially important when you use an alternative Puppet forge with a quite longer URI.
|
Would love to see it in master branch |
Member
|
At first sight it makes sense but this could use some tests to verify we don't accidentally break it later. Also wondering if we should use sha256 instead since security tightened systems might disallow sha1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally to the configuration parameter 'tmp', this parameter is helpful to avoid too long cache paths under Windows.
This is achieved by shortening the cache path part of the Puppet forge URI to the 7 first digits of its SHA1 checksum (like short Git commit hash approach).
Under Windows this shortening is especially important when you use an alternative Puppet forge with a quite longer URI.