Skip to content

Removing pdk-version from metadata #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avitacco merged 1 commit into from
Jul 27, 2026
Merged

Removing pdk-version from metadata #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions internal/build/build_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ func writeTestMetadata(t *testing.T, dir, forgeUser, moduleName, version string)
"requirements": []any{},
"operatingsystem_support": []any{},
"tags": []any{},
"pdk-version": "3.4.0",
}
metaData, err := json.Marshal(meta)
if err != nil {
Expand Down Expand Up @@ -317,7 +316,6 @@ func TestDoBuild_InvalidMetadata(t *testing.T) {
"requirements": []any{},
"operatingsystem_support": []any{},
"tags": []any{},
"pdk-version": "3.4.0",
}
metaData, err := json.Marshal(meta)
if err != nil {
Expand Down
2 changes: 0 additions & 2 deletions internal/module/metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ type Metadata struct {
Requirements []Requirement `json:"requirements"`
OperatingSystem []OperatingSystem `json:"operatingsystem_support"`
Tags []string `json:"tags"`
PdkVersion string `json:"pdk-version"`
// TemplateURL, TemplateRef, and TemplateCommit were written by jig 1.x
// to record which template repository the module was scaffolded from.
// jig 2.x records template provenance in jig.toml instead and does not
Expand Down Expand Up @@ -69,7 +68,6 @@ func NewMetadata(name string, forgeUser string, author string) Metadata {
},
OperatingSystem: []OperatingSystem{},
Tags: []string{},
PdkVersion: "3.4.0",
}
}

Expand Down
3 changes: 1 addition & 2 deletions internal/module/metadata_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,7 @@ func TestReadMetadata(t *testing.T) {
"dependencies": [],
"requirements": [],
"operatingsystem_support": [],
"tags": [],
"pdk-version": "3.4.0"
"tags": []
}`
if err := os.WriteFile(path, []byte(content), 0644); err != nil {
t.Fatal(err)
Expand Down
1 change: 0 additions & 1 deletion internal/scaffold/helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ func makeModuleDir(t *testing.T, forgeUser, moduleName string) string {
"requirements": []any{},
"operatingsystem_support": []any{},
"tags": []any{},
"pdk-version": "3.4.0",
}
data, err := json.Marshal(meta)
if err != nil {
Expand Down