Adding stopWithTask tag and onTaskRemoved to the service#32
Open
mathBordin wants to merge 2 commits into
Open
Conversation
added 2 commits
November 13, 2020 22:54
I noticed that my application was killed because the foreground service continued to run after closing the app. So, I made this change to solve this problem by adding the stopWithTask tag on the AndroidManifest.xml and calling stopSelf inside onTaskRemoved.
|
@mathBordin It's killing the notification but when I checked the app status on the app info it seems app still working in the background and the option 'force stop' is available. And I checked it starting the service causing this without foreground service when I kill the app there is no 'force stop' option available. I think it's not exactly killing the service |
gustavoabel
approved these changes
Sep 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that my application wasn't killed because the foreground service continued to run after closing the app, even calling stopService on componentWillUnmount. So, I made this change to solve this problem by adding the stopWithTask tag on the AndroidManifest.xml and calling stopSelf inside onTaskRemoved.
You can check for this problem by verifying that the application's PID is the same after reopening it. In fact, it continues to run even when it is closed.
Before changes:
After changes:
This change was based on this topic on Stack Overflow: https://stackoverflow.com/questions/53334235/how-to-properly-stop-a-foreground-service