Skip to content

Proposed fix for issue #20, java.lang.ClassCastException #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gmccobb wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Proposed fix for issue #20, java.lang.ClassCastException #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e8f2e3b
Proposed fix for issue #20, java.lang.ClassCastException: java.lang.D…
gmccobb Jan 14, 2020
264d7e3
Update README.md
gmccobb Jan 15, 2020
1b8138f
Update README.md
gmccobb Jan 15, 2020
53a1650
Update README.md
gmccobb Jan 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# foreground-service-library-test

# react-native-foreground-service
This is a clone of react-native-foreground-service with a small change. An exception thrown when the priority is parsed in the NotificationHelper.java's buildNotification method is fixed.

A foreground service performs some operation that is noticeable to the user.
For example, an audio app would use a foreground service to play an audio track.
Expand All @@ -11,7 +12,7 @@ See [the Android official documentation](https://developer.android.com/guide/com

## Getting started

`$ npm install @voximplant/react-native-foreground-service --save`
`$ npm install foreground-service-library-test --save`

### Automatic installation (Android only)

Expand Down Expand Up @@ -154,4 +155,4 @@ NotificationConfig
| title | Notification title | yes |
| text | Notification text | yes |
| icon | Icon name | yes |
| priority | Priority of this notification. One of: <ul><li>&nbsp;0 – PRIORITY_DEFAULT (by default)</li><li>-1 – PRIORITY_LOW</li><li>-2 – PRIORITY_MIN</li><li>&nbsp;1 – PRIORITY_HIGH</li><li>&nbsp;2 – PRIORITY_MAX</li></ul> | no |
| priority | Priority of this notification. One of: <ul><li>&nbsp;0 – PRIORITY_DEFAULT (by default)</li><li>-1 – PRIORITY_LOW</li><li>-2 – PRIORITY_MIN</li><li>&nbsp;1 – PRIORITY_HIGH</li><li>&nbsp;2 – PRIORITY_MAX</li></ul> | no |
2 changes: 1 addition & 1 deletion android/src/main/java/com/voximplant/foregroundservice/NotificationHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ Notification buildNotification(Context context, Bundle notificationConfig) {
notificationBuilder = new Notification.Builder(context);
}

int priorityInt = notificationConfig.containsKey("priority") ? notificationConfig.getInt("priority"): Notification.PRIORITY_HIGH;
int priorityInt = notificationConfig.containsKey("priority") ? (int)notificationConfig.getDouble("priority"): Notification.PRIORITY_HIGH;

int priority;
switch (priorityInt) {
Expand Down