Repository navigation
Dedupe getVouches Stellar query into shared helper + repair broken-merge syntax in chain.ts - #302
Open
7777add7777-ai wants to merge 1 commit into
Open
7777add7777-ai wants to merge 1 commit into
7777add7777-ai wants to merge 1 commit into
Conversation
…n-merge syntax in chain.ts - lib/stellar.js + server/utils/chain.ts now both call simulateGetVouches() from lib/shared/getVouches.ts instead of duplicating the TransactionBuilder/simulate/parse block (issue vouchlabsio#66) - remove broken-merge debris in server/utils/chain.ts: stray duplicate contentToField/FR fragment and the duplicated const account in getVouchesOnChain - chain.test.ts: 4/4 passing locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #66 — dedupes the Stellar
get_vouchesquery path.Both callers now call the shared helper
simulateGetVouches()inpackages/web/lib/shared/getVouches.tsinstead of each carrying its own copy of theContract.call→TransactionBuilder→simulateTransaction→scValToNativeblock:packages/web/lib/stellar.js(getVouches)packages/web/server/utils/chain.ts(getVouchesOnChain)Also repaired (broken-merge debris in
server/utils/chain.ts)contentToFieldstub with imports in the middle of the file and an unclosedconst FR = BigInt(that made the module unparseableconst accountdeclaration insidegetVouchesOnChainVerification
vitest run test/chain.test.ts→ 4/4 passing locallymain(pre-change) 9 of 10 test files already fail to transform due to other unrelated broken-merge files (e.g.server/api/verify-human.post.ts); those are left untouched and out of scope for this issue.Payment (any of)
0x16D07De01bDbfE0cBc4624503B228BaaC3F53e793KcpumPNcBCYPzwwx75WVJ28SuSHrgdik72GPapyKv8WTCpF7Cy32nLEkLpUDFkSzoBxKpgnYQA1B9