fix(capabilities): read openclaw host-compat from package.json#404
fix(capabilities): read openclaw host-compat from package.json#404claytonlin1110 wants to merge 1 commit into
Conversation
kb.capabilities' host_compat block read openclaw.compat.pluginApi from
openclaw.plugin.json, but the manifest deliberately excludes a
top-level "openclaw" key (test_openclaw_plugin_manifest.py's
dead-dialect-fields check) -- so _load_host_compat() always returned
{}, failing the vouchdev#237 drift tests unconditionally. package.json is the
one place openclaw.compat.pluginApi actually lives; point the reader
(and the mirroring test fixture) there instead.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@plind-junior Hi, would you review plz? |
summary
kb.capabilities'shost_compatblock readopenclaw.compat.pluginApifromopenclaw.plugin.json, but the manifest deliberately excludes a top-level"openclaw"key (test_openclaw_plugin_manifest.py's dead-dialect-fields check, from feat(openclaw): declarevouch-contextengine contract #228) — so_load_host_compat()always returned{}, unconditionally failing the two chore(release): pin pluginApi compat baseline in kb.capabilities #237 drift-detection tests ontest.package.jsonis the one placeopenclaw.compat.pluginApiactually lives (already enforced bytest_package_json_declares_entry_and_compat). Points the reader — and the mirroring test fixture intests/test_capabilities.py— atpackage.jsoninstead.upstream/testcheckout.test plan
tests/test_capabilities.py— all pass, including the two previously-failing drift-detection teststests/test_openclaw_plugin_manifest.py— still green (confirms the manifest's dead-dialect-fields invariant is untouched)ruff checkcleanmypy srcclean (no new errors)🤖 Generated with Claude Code