Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/vouch/storage.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,15 @@ def _deserialize_page(text: str) -> Page:
return Page(body=body, **meta)


def _load_page_or_skip(path: Path) -> Page | None:
"""Parse one page file; skip corrupt/unreadable files like ``_load_or_skip``."""
try:
return _deserialize_page(path.read_text(encoding="utf-8"))
except (yaml.YAMLError, ValidationError, UnicodeDecodeError, OSError, ValueError) as e:
_log.warning("skipping unreadable page %s: %s", path.name, e)
return None


class KBStore:
"""File-backed CRUD layer. Pure I/O — no business logic."""

Expand Down Expand Up @@ -550,8 +559,9 @@ def list_pages(self) -> list[Page]:
if not pdir.is_dir():
return []
return [
_deserialize_page(p.read_text(encoding="utf-8"))
pg
for p in sorted(pdir.glob("*.md"))
if (pg := _load_page_or_skip(p)) is not None
]

# --- entities ----------------------------------------------------------
Expand Down
9 changes: 9 additions & 0 deletions tests/test_storage.py
Original file line number Diff line number Diff line change
Expand Up @@ -860,3 +860,12 @@ def test_list_claims_skips_unreadable_file(store: KBStore) -> None:

claims = store.list_claims()
assert [c.id for c in claims] == ["c-ok"]


def test_list_pages_skips_unreadable_file(store: KBStore) -> None:
"""One corrupt page must not take down vouch search/status/lint."""
store.put_page(Page(id="p-ok", title="ok", body="content"))
(store.kb_dir / "pages" / "p-bad.md").write_text("not valid frontmatter")

pages = store.list_pages()
assert [p.id for p in pages] == ["p-ok"]