Repository navigation
Restore AMS spool configuration and report untyped slots - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore
ams seton current main for configuring non-RFID spool metadata. Writes require--confirm, an idle printer, physical filament detection, and verified read-back. Preflight now distinguishes a detected spool with no material set from an empty slot and points to command help. Existing gate names, exit codes, andloadedsemantics stay compatible; physical presence is exposed as nullablepresent.Validation:
GOTOOLCHAIN=go1.26.10 make cipassed. Regression tests reproduced the missing command and misleading empty-slot error before the fix. Read-only printer checks confirmed that A3's metadata dry-run exits 0; a strict send dry-run exits 9 with the untyped-tray diagnosis. No printer metadata was written. Independent code review approved with nits, and the rendered FAQ review approved.Known limitations from the restored implementation: non-Generic profile IDs remain caller-checked against the material type, missing AMS-status telemetry retains its existing handling, and models beyond X1 Carbon have no live verification. Human status and filament-load wording remain separate follow-ups.
Screenshots
Updated settings FAQ, desktop (1440 × 900):
Updated settings FAQ, mobile (390 × 844):