Repository navigation
Accept checked filament remaining estimates - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMS remaining telemetry can report 0 g on a spool that still has filament. Add repeatable
--filament-remaining A2=50gtopreflightandprint sendso a checked amount can be used for that invocation.The amount must still cover the job plus the existing 15% and 5 g reserve. A sufficient estimate reports WARN with the stated amount and original AMS reading; an insufficient estimate stays FAIL. Slot mapping, material, printer readiness, confirmation and dry-run behavior remain enforced. JSON includes the estimate, raw telemetry and required grams. The bundled agent skill and flag reference document using a physically checked amount reported by a person.
Validation:
GOTOOLCHAIN=go1.26.10 make cipassed, including race tests. Regression tests cover strict mode, unknown telemetry, reserve boundaries, malformed job usage, slot validation, multiple filaments and confirmed sends through fakes. Read-only hardware dry-runs confirmed the amount warning while a busy printer continued to fail the idle gate.Review gate: independent code and CLI API review approved with nits; help text, recovery hints and required-amount precision addressed. Independent review also approved the fix that preserves amount failures for nonfinite job usage.