Fix flaky food-plan suggestion e2e tests by isolating them in an ephemeral household#613
Merged
Merged
Conversation
…meral household The deploy e2e workflow's suggestion tests asserted a freshly-created recipe ranks within the top N results of GET /api/food-plan/suggestions, which scores every recipe in the household. The shared deploy household had already accumulated 200+ recipes that permanently outscore a brand new "not planned yet" candidate, so no result count can make the assertion reliable there — a prior fix (raising MaxCount, cleaning up other specs' leaks) didn't hold because it couldn't undo data that had already leaked into the persistent household. Add useEphemeralHousehold() to food-plans.spec.ts: it creates a throwaway household via POST /api/households and points the page at it, so the two suggestion tests run against a household with zero pre-existing recipes and get deterministic rankings. Deleting the household in `finally` also makes its recipes/entries invisible to every other household's suggestions, so per-recipe/entry cleanup is no longer needed either.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy e2e workflow's suggestion tests asserted a freshly-created
recipe ranks within the top N results of GET /api/food-plan/suggestions,
which scores every recipe in the household. The shared deploy household
had already accumulated 200+ recipes that permanently outscore a brand
new "not planned yet" candidate, so no result count can make the
assertion reliable there — a prior fix (raising MaxCount, cleaning up
other specs' leaks) didn't hold because it couldn't undo data that had
already leaked into the persistent household.
Add useEphemeralHousehold() to food-plans.spec.ts: it creates a
throwaway household via POST /api/households and points the page at it,
so the two suggestion tests run against a household with zero
pre-existing recipes and get deterministic rankings. Deleting the
household in
finallyalso makes its recipes/entries invisible toevery other household's suggestions, so per-recipe/entry cleanup is no
longer needed either.