Fix hang on backendRequest error - #84
Open
jbandhauer wants to merge 1 commit into
Open
Conversation
_player_engine.php blocks indefinately when the state sent by the client matches the current state. But, in the case where the backendRequest hits an error, the app starts trying to reconnect in a setTimeout loop while it shows a modal UI. So, we don't want _player_engine to block. This adds an option to backendRequest to send state or not for the cases we want it to block or not.
|
|
||
| function backendRequest() { | ||
| function backendRequest(send_state) { | ||
| url = send_state ? ('_player_engine.php?state=' + GUI.MpdState['state']) : '_player_engine.php' |
Author
There was a problem hiding this comment.
Ah, been doing too much Ruby lately. This should be var url = ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_player_engine.php blocks indefinately when the state sent by the client matches the current state.
But, in the case where the backendRequest hits an error, the app starts trying to reconnect in a
setTimeout loop while it shows a modal UI. So, we don't want _player_engine to block.
This adds an option to backendRequest to send state or not for the cases we want it to block or not.