This repository was archived by the owner on Nov 11, 2026. It is now read-only.
Repository navigation
Plate figure: drop the cut line's side walls - #612
Merged
Merged
Conversation
…e.py does Both lines now come from score.scored_lines, split out of cutline_distance, so the figure uses the scorer's masking. The drawn fine-tune line keeps only the region's distal face; the region's side walls, where it ends inside the tibia, read as long vertical errors on OA6-11RK V223, OA8-21L V194 and OA6-5RK V163. Scores unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
training/plate-finetune/README.mdno longer draws long vertical lines at the ends of the fine-tune's cut line (OA6-11RK V223, OA8-21L V194, OA6-5RK V163).Why
After #605 the fine-tune cut line was drawn through every voxel of the voted region's cut-side boundary. That boundary also holds the region's side walls, where the region ends inside the tibia, and three panels showed them as tall vertical lines that read as errors.
Design decisions
score.pymasks them.score.pynow exposesscored_lines(the label cut and the predicted boundary, outside ignore voxels and columns), used bycutline_distanceand by the figure, so the figure can't drift from the scorer. The reference line now has gaps where the score ignores voxels or columns.Walkthrough
Regenerate the figure
~/experiments/plate-dataand~/experiments/plate-figure/stock-growth-platepresent.cd training/plate-finetune && uv run --group figure python make_comparison_figure.py(about 6 min, CPU).What changed
score.py:scored_linessplit out ofcutline_distance; scoring is unchanged.make_comparison_figure.py:release_predictionbuilds both lines throughscored_linesand keeps the distal face of the predicted one.Risk and where to look
release_prediction. A steep piece of a real cut line would also be dropped from the drawing (not from the score).Knowledge layers, docs and deletions
training/plate-finetune/README.md: caption says which voxels each line is drawn through.Contract changes
None.
packages/contractsis untouched.Verification
Left out