Repository navigation
feat(qemu): add phase 2 start plan and remote disk secrets - #34
Open
msdmazvoid wants to merge 4 commits into
Open
msdmazvoid wants to merge 4 commits into
msdmazvoid wants to merge 4 commits into
Conversation
Add protocol-neutral StartPlan support, iSCSI drive construction, per-disk secret files, remote-source disk validation, HMP run-state/resume, and stale-secret cleanup.
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of the kouja storage backend, stacked on
feat/kouja-storage-backend-phase1.This adds the QEMU-side contract for remote disks: a prepared start plan, protocol-neutral disk argument construction, per-disk secret files, remote-source validation, and HMP run-state/resume support.
What changed
qemu.StartPlanandStartWithPlan, while keepingStartfor local-only VMs.buildDiskArgsfor local and iSCSI attachments; NVMe/TCP and RBD return clear unsupported errors until their builders land.info status,Paused,Resume, andErrNotPaused.Verification
go test ./... -count=1go vet ./...gofmtcleanChain
Base PR: #33 (
feat/kouja-storage-backend-phase1). Merge in order #32 → #33 → this PR.Review-artifact scratch files are intentionally excluded.