Skip to content

Use Ginkgo and Gomega for all tests - #2

Merged
msdmazvoid merged 1 commit into
mainfrom
test/ginkgo-all
Nov 6, 2026
Merged

msdmazvoid merged 1 commit into
mainfrom
test/ginkgo-all

Conversation

@msdmazvoid

Copy link
Copy Markdown
Contributor

Summary

  • Converts every existing unit and integration test package to a Ginkgo v2 suite.
  • Runs the existing test cases through Ginkgo's GinkgoTB/GinkgoTB() adapter so current assertions and fixtures continue to work.
  • Adds Gomega as the assertion framework and registers it for every suite.
  • Keeps the BDD-style test/bdd suite using explicit Gomega assertions.
  • Preserves coverage at 80.6% and the existing CI coverage gate.
  • No GoMock code is needed at this point; the current interfaces are covered by focused test doubles.

Why

This makes Ginkgo + Gomega the standard test framework for the repository rather than applying it only to the new BDD suite.

Test plan

  • go test -tags=unit ./...
  • go test -tags=integration ./test/integration/...
  • go test -tags=e2e ./test/e2e/...
  • go test -tags=csi_sanity ./test/csi/...
  • make coverage-check
  • go vet ./...
  • golangci-lint run
  • GitHub Actions CI

@msdmazvoid
msdmazvoid merged commit cb830cf into main Nov 6, 2026
2 checks passed
@msdmazvoid
msdmazvoid deleted the test/ginkgo-all branch November 6, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant