Skip to content

docker: user fgc instead of root - #478

Open
vogler wants to merge 1 commit into
devfrom
docker-rootless
Open

docker: user fgc instead of root#478
vogler wants to merge 1 commit into
devfrom
docker-rootless

Conversation

@vogler

@vogler vogler commented May 25, 2025

Copy link
Copy Markdown
Owner

Fixes #468.

This works when running with a fresh volume:
image
But fails for existing volumes which have /fgc/data owned by root:
image

I guess one could give people a docker run command to fix permissions, but not sure if it's worth the headache.

Notes:

@github-actions

github-actions Bot commented May 25, 2025

Copy link
Copy Markdown

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ BASH bash-exec 1 0 0 0.01s
✅ BASH shellcheck 1 0 0 0.06s
✅ BASH shfmt 1 0 0 0 0.01s
⚠️ COPYPASTE jscpd yes 8 no 2.72s
⚠️ DOCKERFILE hadolint 1 4 0 0.51s
⚠️ JAVASCRIPT eslint 15 0 1 0 0.75s
✅ JSON jsonlint 7 0 0 0.2s
✅ JSON npm-package-json-lint yes no no 0.46s
✅ JSON prettier 7 0 0 0 0.56s
✅ JSON v8r 7 0 0 8.86s
✅ MARKDOWN markdownlint 2 0 0 0 0.94s
✅ MARKDOWN markdown-table-formatter 2 0 0 0 0.3s
⚠️ REPOSITORY checkov yes 2 no 15.79s
✅ REPOSITORY gitleaks yes no no 0.32s
✅ REPOSITORY git_diff yes no no 0.0s
✅ REPOSITORY grype yes no no 21.15s
⚠️ REPOSITORY kics yes 25 no 2.6s
✅ REPOSITORY secretlint yes no no 0.81s
✅ REPOSITORY syft yes no no 1.05s
✅ REPOSITORY trivy yes no no 4.82s
✅ REPOSITORY trufflehog yes no no 3.33s
⚠️ SPELL cspell 38 247 0 12.18s
⚠️ SPELL lychee 17 11 0 3.0s
✅ YAML prettier 8 0 0 0 0.73s
✅ YAML v8r 8 0 0 7.53s
✅ YAML yamllint 8 0 0 0.57s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@vogler
vogler force-pushed the docker-rootless branch from 325d653 to fdbd71e Compare May 25, 2025 20:13
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots

See analysis details on SonarQube Cloud

Comment thread Dockerfile
# also need to chown ., otherwise we can't create node_modules inside as fgc
RUN mkdir data && chown -R fgc:fgc .
USER fgc
COPY --chown=fgc:fgc package*.json ./

Check notice

Code scanning / KICS (MegaLinter REPOSITORY_KICS)

Chown Flag Exists

The 'Dockerfile' contains the 'chown' flag
vogler added a commit that referenced this pull request Jul 22, 2025
…t (old), #497

- 1.46GB`pipx install apprise` -> as is, need to adjust $PATH (now installed for root, note for #478)
- 1.45GB `pip install apprise --break-system-packages`
- 1.43GB `apt-get install apprise` -> only version 1.7.2 instead of 1.9.3 for pip/pipx
shoyrock added a commit to shoyrock/free-games-claimer that referenced this pull request Apr 18, 2026
…encies

- prime-gaming: fix login error null-check + trim() bug (PR vogler#560)
- prime-gaming: fix username retrieval via dropdown click (PR vogler#560)
- prime-gaming: fix VNC lock file cleanup in entrypoint (PR vogler#560)
- prime-gaming: support regional redirects (luna.amazon.*) (PR vogler#564)
- prime-gaming: dynamic origin for game URLs instead of hardcoded domain (PR vogler#564)
- unrealengine: migrate from UE marketplace to fab.com (PR vogler#576)
- unrealengine: flexible login detection for fab.com (PR vogler#576)
- unrealengine: per-item claiming flow with license selection (PR vogler#576)
- docker: run container as non-root user fgc (PR vogler#478)
- docker: add -nolisten unix to Xvfb for non-root compat (PR vogler#478)
- deps: npm update, 0 vulnerabilities

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants