docker: user fgc instead of root - #478
Open
vogler wants to merge 1 commit into
Open
Conversation
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ BASH | bash-exec | 1 | 0 | 0 | 0.01s | |
| ✅ BASH | shellcheck | 1 | 0 | 0 | 0.06s | |
| ✅ BASH | shfmt | 1 | 0 | 0 | 0 | 0.01s |
| jscpd | yes | 8 | no | 2.72s | ||
| hadolint | 1 | 4 | 0 | 0.51s | ||
| eslint | 15 | 0 | 1 | 0 | 0.75s | |
| ✅ JSON | jsonlint | 7 | 0 | 0 | 0.2s | |
| ✅ JSON | npm-package-json-lint | yes | no | no | 0.46s | |
| ✅ JSON | prettier | 7 | 0 | 0 | 0 | 0.56s |
| ✅ JSON | v8r | 7 | 0 | 0 | 8.86s | |
| ✅ MARKDOWN | markdownlint | 2 | 0 | 0 | 0 | 0.94s |
| ✅ MARKDOWN | markdown-table-formatter | 2 | 0 | 0 | 0 | 0.3s |
| checkov | yes | 2 | no | 15.79s | ||
| ✅ REPOSITORY | gitleaks | yes | no | no | 0.32s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.0s | |
| ✅ REPOSITORY | grype | yes | no | no | 21.15s | |
| kics | yes | 25 | no | 2.6s | ||
| ✅ REPOSITORY | secretlint | yes | no | no | 0.81s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.05s | |
| ✅ REPOSITORY | trivy | yes | no | no | 4.82s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 3.33s | |
| cspell | 38 | 247 | 0 | 12.18s | ||
| lychee | 17 | 11 | 0 | 3.0s | ||
| ✅ YAML | prettier | 8 | 0 | 0 | 0 | 0.73s |
| ✅ YAML | v8r | 8 | 0 | 0 | 7.53s | |
| ✅ YAML | yamllint | 8 | 0 | 0 | 0.57s |
See detailed report in MegaLinter reports
|
| # also need to chown ., otherwise we can't create node_modules inside as fgc | ||
| RUN mkdir data && chown -R fgc:fgc . | ||
| USER fgc | ||
| COPY --chown=fgc:fgc package*.json ./ |
Check notice
Code scanning / KICS (MegaLinter REPOSITORY_KICS)
Chown Flag Exists
This was referenced May 25, 2025
shoyrock
added a commit
to shoyrock/free-games-claimer
that referenced
this pull request
Apr 18, 2026
…encies - prime-gaming: fix login error null-check + trim() bug (PR vogler#560) - prime-gaming: fix username retrieval via dropdown click (PR vogler#560) - prime-gaming: fix VNC lock file cleanup in entrypoint (PR vogler#560) - prime-gaming: support regional redirects (luna.amazon.*) (PR vogler#564) - prime-gaming: dynamic origin for game URLs instead of hardcoded domain (PR vogler#564) - unrealengine: migrate from UE marketplace to fab.com (PR vogler#576) - unrealengine: flexible login detection for fab.com (PR vogler#576) - unrealengine: per-item claiming flow with license selection (PR vogler#576) - docker: run container as non-root user fgc (PR vogler#478) - docker: add -nolisten unix to Xvfb for non-root compat (PR vogler#478) - deps: npm update, 0 vulnerabilities Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #468.
This works when running with a fresh volume:


But fails for existing volumes which have
/fgc/dataowned by root:I guess one could give people a
docker runcommand to fix permissions, but not sure if it's worth the headache.Notes:
fgcvolume? keep root, chown in entrypoint, and later change default user?