Skip to content

fix(ci): restore macOS test event dispatch - #2753

Merged
tamlok merged 2 commits into
masterfrom
fix/macos-ci-event-dispatcher
Sep 19, 2026
Merged

tamlok merged 2 commits into
masterfrom
fix/macos-ci-event-dispatcher

Conversation

@tamlok

@tamlok tamlok commented Sep 19, 2026 •

Copy link
Copy Markdown
Member

Failure

The completed macOS run https://github.com/vnotex/vnote/actions/runs/35443251821 failed search, image-host, update-service, bootstrap, and sync-dialog tests.

The process-wide CoreFoundation dispatcher override also changes QThread worker dispatchers. Meanwhile, the offscreen GUI platform still uses a UNIX main dispatcher, so native QtKeychain completions are not drained.

Fix

  • Remove the process-wide CoreFoundation override.
  • Use a native Qt application on macOS for the eight core/controller tests that perform real keychain operations; retain QCoreApplication on other platforms.
  • Run macOS GUI tests with Cocoa, retaining the disposable unlocked test keychain.
  • Replace the IO-gate regression's sleep windows and latency thresholds with semaphore-held phases and nonblocking lock probes. Join the worker before asserting, so failures report normally.
  • Application behavior and CTest timeouts remain unchanged.

Verification

@tamlok
tamlok deployed to Mac-code-sign September 19, 2026 17:10 — with GitHub Actions Active
@tamlok
tamlok merged commit fa106f9 into master Sep 19, 2026
4 checks passed
@tamlok
tamlok deleted the fix/macos-ci-event-dispatcher branch September 19, 2026 18:36

This branch was successfully deployed

1 active deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant