fix: an explicit 'no' to auto healing must send enableAutoHealing=false - #60
Closed
vks-team wants to merge 1 commit into
Closed
fix: an explicit 'no' to auto healing must send enableAutoHealing=false#60vks-team wants to merge 1 commit into
vks-team wants to merge 1 commit into
Conversation
Field bug: the user answered 'no' to the auto-healing question, the agent
encoded that as an OMITTED autoHealingConfig, and the platform default (ON)
won — the cluster came up with auto healing enabled against the user's
answer. configure_auto_healing itself is correct; the gap was in the create
flow.
- guide step k: always send the field explicitly — 'no' ->
{enableAutoHealing: false}; 'yes' -> ask exactly one of maxUnhealthy |
unhealthyRange (+ optional timeoutUnhealthy)
- CreateClusterComboDto.autoHealingConfig description: omitted => platform
default applies (currently ON); never encode the user's 'no' as omission
- AutoHealingConfig docstring documents the exactly-one rule and that
{enableAutoHealing: false} alone is a valid body (API-confirmed)
Contributor
Author
|
Closing — the fix lands on the API side instead: an omitted autoHealingConfig will no longer apply any platform default, so the MCP flow's omit-on-'no' behavior is correct as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field bug (QC)
In the create-cluster flow the user answered "no" to the auto-healing question — the cluster still came up with auto healing enabled.
Root cause
configure_auto_healingis correct (explicit required param, sends what it's told). The gap is in the create flow: the guide listedautoHealingConfigas "Tuỳ chọn", so the agent encoded the user's "no" as an omitted field — and an omitted field means the platform default applies, which is currently ON. The user's "no" never reached the API. (The CLI behaves the same way with an empty flag, so nothing contradicted it until QC checked.)Fix — make the outcome deterministic regardless of the platform default
autoHealingConfig: {enableAutoHealing: false}(never omit); "yes" → ask exactly ONE ofmaxUnhealthy|unhealthyRange(+ optionaltimeoutUnhealthy5–180m). The confirm plan now shows the explicit choice.CreateClusterComboDto.autoHealingConfigdescription: omitted ⇒ platform default (currently ON); never encode a 'no' as omission.AutoHealingConfigdocstring: exactly-one rule when enabling;{enableAutoHealing: false}alone is a valid body (API-confirmed).enableAutoHealing: false+ never-omit wording).Test
278 passed, ruff clean.