feat(vks): optionally attach a node group in create-cluster (nodeGroup) - #31
Closed
vks-team wants to merge 1 commit into
Closed
feat(vks): optionally attach a node group in create-cluster (nodeGroup)#31vks-team wants to merge 1 commit into
vks-team wants to merge 1 commit into
Conversation
The updated spec adds an optional singular nodeGroup object to the create request and deprecates the nodeGroups array. Add optional node-group flags to create-cluster: a node group is attached only when --node-group-name is set (then --flavor-id/--disk-type/--ssh-key-id are required), sent under the nodeGroup field. Omit them and only the control plane is created. Reviewed update-nodegroup against the new UpdateNodeGroupDto (required=none): the CLI already treats all body fields as optional, so no change is needed there. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context — spec review
The updated VKS spec (
CreateClusterComboDto, the POST /v1/clusters body) now has:nodeGroup(object, optional) — attach a node group at creation.nodeGroups(array) — deprecated.And
UpdateNodeGroupDtonow hasrequired: none(all body fields optional).Review result
nodeGroup, don't use deprecatednodeGroupsnumNodes/securityGroups/autoScaleConfig/upgradeConfigas optional (only the path params are required). No code change.Changes (create-cluster)
Optional inline node group, attached only when
--node-group-nameis set; then--flavor-id,--disk-type,--ssh-key-idare required. Optional:--os,--disk-size,--num-nodes,--private-nodes,--security-groups,--labels,--taints. Omit all → control plane only (v1.5.0/v1.6.0 behavior preserved).nodeGroupobject; the deprecatednodeGroupsarray is never sent.subnetIdreuses the cluster--subnet-idwhen provided.Behavior
nodeGroupin body.--node-group-namewithout the required trio →Error: attaching a node group requires: ....Testing
go vet ./...clean; fullgo test ./...passes; build clean; verified 3 dry-run scenarios via the binary.This edits
docs/commands/vks/create-cluster.mdin its current (definition-list) format. PR #30 (AWS-CLI-style docs reformat) also rewrites this file — whichever merges second needs a quick conflict resolution (keep both: the new node-group options in the EKS format).🤖 Generated with Claude Code