fix: add recreate_if_expired_at attribute - #576
Open
azrdev wants to merge 2 commits into
Open
Conversation
Signed-off-by: Jonathan Biegert <jonathan.biegert@sva.de>
recreate_if_expired_at attribute
tenthirtyam
marked this pull request as draft
March 31, 2025 13:35
tenthirtyam
requested changes
Mar 31, 2025
tenthirtyam
left a comment
Contributor
There was a problem hiding this comment.
CI is failing on the lint.
run golangci-lint
only new issues on pull_request: /tmp/tmp-5435-EsOXVA5EYXCV/pull.patch
Running [/home/runner/golangci-lint-1.60.3-linux-amd64/golangci-lint run --new-from-patch=/tmp/tmp-5435-EsOXVA5EYXCV/pull.patch --new=false --new-from-rev= --issues-exit-code=1] in [/home/runner/work/terraform-provider-vra/terraform-provider-vra] ...
Error: vra/resource_deployment.go:65:9: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func(ctx context.Context, d *schema.ResourceDiff, meta interface{}) bool {
^
Error: issues foundMarking as draft until ready for review.
azrdev
force-pushed
the
recreate-expired-deployments
branch
from
April 2, 2025 06:42
4418987 to
af0ec80
Compare
azrdev
marked this pull request as ready for review
April 2, 2025 06:44
tenthirtyam
marked this pull request as draft
April 2, 2025 12:59
tenthirtyam
requested changes
Apr 2, 2025
tenthirtyam
left a comment
Contributor
There was a problem hiding this comment.
@azrdev - the action is failing on the following:
Error: vra/resource_deployment.go:65:52: unused-parameter: parameter 'meta' seems to be unused, consider removing or renaming it as _ (revive)
func(_ context.Context, d *schema.ResourceDiff, meta interface{}) bool {
^You can install golangci-lint and run it locally from the root of the project with golangci-lint run.
more idiomatic Go. Change requested by @tenthirtyam Signed-off-by: Jonathan Biegert <jonathan.biegert@sva.de>
azrdev
force-pushed
the
recreate-expired-deployments
branch
from
April 3, 2025 08:04
af0ec80 to
e0e76f7
Compare
azrdev
marked this pull request as ready for review
April 3, 2025 08:04
Author
|
@tenthirtyam thanks for your patience, and sorry for not running the linter in the first place. I did so now locally, and get no more findings with e0e76f7 |
Author
|
What is missing for this to be merged (or #473 to be fixed some other way)? Can I do something? |
tenthirtyam
removed their request for review
December 16, 2025 18:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#514 was auto-closed before I noted @tenthirtyam requested changes. I now implemented these, please re-check
for PR context, see #473 especially #473 (comment)