Skip to content

fix: add recreate_if_expired_at attribute - #576

Open
azrdev wants to merge 2 commits into
vmware:mainfrom
azrdev:recreate-expired-deployments
Open

fix: add recreate_if_expired_at attribute#576
azrdev wants to merge 2 commits into
vmware:mainfrom
azrdev:recreate-expired-deployments

Conversation

@azrdev

@azrdev azrdev commented Mar 31, 2025

Copy link
Copy Markdown

#514 was auto-closed before I noted @tenthirtyam requested changes. I now implemented these, please re-check


for PR context, see #473 especially #473 (comment)

Signed-off-by: Jonathan Biegert <jonathan.biegert@sva.de>
@tenthirtyam tenthirtyam changed the title fix: add vra_deployment.recreate_if_expired_at attribute fix: add recreate_if_expired_at attribute Mar 31, 2025
@tenthirtyam
tenthirtyam marked this pull request as draft March 31, 2025 13:35

@tenthirtyam tenthirtyam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing on the lint.

run golangci-lint
  only new issues on pull_request: /tmp/tmp-5435-EsOXVA5EYXCV/pull.patch
  Running [/home/runner/golangci-lint-1.60.3-linux-amd64/golangci-lint run --new-from-patch=/tmp/tmp-5435-EsOXVA5EYXCV/pull.patch --new=false --new-from-rev= --issues-exit-code=1] in [/home/runner/work/terraform-provider-vra/terraform-provider-vra] ...
  Error: vra/resource_deployment.go:65:9: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
  			func(ctx context.Context, d *schema.ResourceDiff, meta interface{}) bool {
  			     ^
  
  Error: issues found

Marking as draft until ready for review.

@azrdev
azrdev force-pushed the recreate-expired-deployments branch from 4418987 to af0ec80 Compare April 2, 2025 06:42
@azrdev
azrdev marked this pull request as ready for review April 2, 2025 06:44
@azrdev
azrdev requested a review from tenthirtyam April 2, 2025 06:45
@tenthirtyam
tenthirtyam requested a review from frodenas April 2, 2025 12:57
@tenthirtyam
tenthirtyam marked this pull request as draft April 2, 2025 12:59

@tenthirtyam tenthirtyam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azrdev - the action is failing on the following:

  Error: vra/resource_deployment.go:65:52: unused-parameter: parameter 'meta' seems to be unused, consider removing or renaming it as _ (revive)
  			func(_ context.Context, d *schema.ResourceDiff, meta interface{}) bool {
  			                                                ^

You can install golangci-lint and run it locally from the root of the project with golangci-lint run.

more idiomatic Go. Change requested by @tenthirtyam

Signed-off-by: Jonathan Biegert <jonathan.biegert@sva.de>
@azrdev
azrdev force-pushed the recreate-expired-deployments branch from af0ec80 to e0e76f7 Compare April 3, 2025 08:04
@azrdev
azrdev marked this pull request as ready for review April 3, 2025 08:04
@azrdev

azrdev commented Apr 3, 2025

Copy link
Copy Markdown
Author

@tenthirtyam thanks for your patience, and sorry for not running the linter in the first place. I did so now locally, and get no more findings with e0e76f7

@azrdev

azrdev commented Nov 4, 2025

Copy link
Copy Markdown
Author

What is missing for this to be merged (or #473 to be fixed some other way)? Can I do something?

@tenthirtyam
tenthirtyam removed their request for review December 16, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Needs Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants