Repository navigation
fix(examples): pin the complete example to the published provider version - #24
Merged
Merged
Conversation
…sion The example pinned = 0.1.0-rc.1, a version that no longer exists now that 0.1.0 is published, so terraform init failed with "no available releases match the given constraints". The packaging smoke test only kept working because it rewrote that pin to the version under test, which made the stale constraint invisible. Pin the published version and derive the smoke-test constraint by pattern so a release no longer needs a source edit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
examples/complete/main.tfpinsvmvarela/github-enterpriseto= 0.1.0, the version published in the Terraform Registry.scripts/smoke_package.pyderives the version constraint from the example by pattern instead of matching a hard-coded string.docs/guides/releases.mdverifies the published0.1.0artifacts in its console example.Why
The example pinned
= 0.1.0-rc.1. That tag and release were removed before0.1.0was published, so the documented example no longer initialized:The packaging smoke test passed only because it rewrote the constraint to the version under test, which hid the stale pin; it also had to be edited by hand on every release.
How tested
terraform initandterraform validatein a copy ofexamples/completeagainst the public registry:vmvarela/github-enterprise v0.1.0installed with a valid signature (key ID 284588A61CDA90B9) alongsideintegrations/github v6.13.0, configuration valid.0.1.0and0.2.3);python3 -m py_compile scripts/smoke_package.py.terraform fmt -check -recursive examples,make docswith no generated diff,go vet ./...,git diff --check.make package-checkrequires Linux, so thepackageCI job is the only valid signal for it.Remaining work
Live acceptance against a dedicated test enterprise (#6) is still pending, and the provider is not yet listed in the OpenTofu Registry.
Refs #6