Fix handle nullable types in typescript generated client#39
Merged
sas1024 merged 5 commits intoJun 16, 2026
Merged
Conversation
pont1s
changed the title
pont1s
changed the title
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the TypeScript codegen to model “optional” schema fields as null-able (via | null) instead of optional properties (?), and adjusts generated class defaults accordingly.
Changes:
- Removes
?optional markers from generated TS interfaces and classes. - Renames the generated field metadata from
OptionaltoNullableand appends| nullto nullable field types. - Updates TS golden/testdata outputs to reflect
| nullandnull!defaults.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| typescript/typescript_template.go | Stops emitting optional (?) properties in generated interfaces/classes. |
| typescript/typescript_client.go | Reinterprets “optional” as “nullable”, appends ` |
| typescript/testdata/catalogue_with_types_only.ts | Updates golden output: optional child becomes `IGroup |
| typescript/testdata/catalogue_with_classes.ts | Updates golden output: uses null! for non-nullable fields and ` |
| typescript/testdata/catalogue_client.ts | Updates golden output: optional child becomes `IGroup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+150
to
+152
| if result == "null" && !t.Nullable { | ||
| result = "null!" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated TypeScript client currently declares nullable fields (Go pointers/optional values) as
field?: T, which in TS meansT or omitted from object, as if the field were "cut out" from the JSON response. This does not correspond to the behavior of the real API: the zenrpc/Go server serializes nil as "field": null (the field is present with a null value), rather than omitting them.| nullreflects the real shape of the response?is kept for the request side — the server accepts requests with the field omitted