Skip to content

Fix critical resolution mismatch and memory tracking bugs #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix critical resolution mismatch and memory tracking bugs #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf4ad55
Initial plan
Copilot Dec 16, 2025
46d2be4
Fix serious logic errors: resolution calculation and memory tracking
Copilot Dec 16, 2025
73058a5
Fix memory tracking: increment current_size after adding primitive to…
Copilot Dec 16, 2025
249b5f7
Complete code review: all serious logic errors fixed and validated
Copilot Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions _codeql_detected_source_root
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
./path-tracer-core
2 changes: 1 addition & 1 deletion path-tracer-core/src/processors/master/master.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ master::~master()
void master::run()
{
this->resolution =
math::uvec2((m_worker_info.max_x - m_worker_info.min_x), (m_worker_info.max_y - m_worker_info.min_y));
math::uvec2((m_worker_info.max_x - m_worker_info.min_x) + 1, (m_worker_info.max_y - m_worker_info.min_y) + 1);
this->sample_count = m_worker_info.samples;
this->m_should_terminate = false;
this->m_completed_rays = 0;
Expand Down
3 changes: 2 additions & 1 deletion path-tracer-preprocessor/preprocessor-function/preprocess/preprocessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,9 @@ def get_split_scene(self) -> SplitScene:
if mesh.name not in work: work[mesh.name] = []
work[mesh.name].append(prim_id)
worker_info['total_size'] += prim_size
current_size += prim_size

if (self.memory_per_worker_GB is not None and (current_size + prim_size) >= self.memory_per_worker_GB) or \
if (self.memory_per_worker_GB is not None and current_size >= self.memory_per_worker_GB) or \
(self.num_workers is not None and (current_primitive >= total_primitives / self.num_workers) and
current_worker_id < self.num_workers):

Expand Down