Add workload lint + CONTRIBUTING for pre-merge validation#41
Draft
stecasta wants to merge 1 commit into
Draft
Conversation
Adds scripts/lint_workload.py (schema via parse_workload + pipeline-generation check, no GPU required), wires it as a buildkite PR gate and a pre-commit hook, and documents the validate-before-merge flow (lint locally, PR lint gate, then a scoped WORKLOADS build on hardware). parse_workload gains SKIP_TASK_REGISTRY so the lint runs without lm_eval installed. Signed-off-by: Stefano Castagnetta <scastagnetta@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives perf-eval a pre-merge validation story so a broken recipe fails in review instead of at 3am on a GPU.
scripts/lint_workload.py: validates a recipe with no GPU (schema viaparse_workload+ confirmsgenerate_pipelineemits a step). Modes: explicit paths,--changed(vs origin/main),--all.lint workloadsstep: automatic gate on every PR.CONTRIBUTING.mddocumenting: lint locally, PR lint gate, then a scopedWORKLOADS=build to validate on hardware.parse_workloadgainsSKIP_TASK_REGISTRYso the lint runs withoutlm_evalinstalled.Validated locally: 17/17 existing recipes pass; a deliberately broken recipe (bad GPU, bogus task field) fails with a clear message.
Draft for now to gather feedback on the approach before wiring the CI gate.
AI-assisted (Claude Code).