Add "perfectblend" prebaked dataset and "ultrachat" alias - #3060
Add "perfectblend" prebaked dataset and "ultrachat" alias#3060kylesayrs wants to merge 1 commit into
Conversation
Add "perfectblend" as a registered dataset pointing to mlabonne/open-perfectblend, enabling `oneshot(model, dataset="perfectblend")`. Also add "ultrachat" as an alias for the existing "ultrachat_200k" dataset for convenience. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merge Protections🔴 1 of 1 protections blocking · waiting on 👀 reviews
🔴 Require one maintainer reviewWaiting for any of
This rule is failing.All PRs must have at least one approving review from a maintainer before merging.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the PerfectBlendDataset class to support the mlabonne/open-perfectblend dataset and adds an alias to the UltraChatDataset registration. The review feedback suggests stacking @register decorators instead of using the alias keyword argument to ensure compatibility, and recommends adopting defensive programming in PerfectBlendDataset.dataset_template to safely handle missing or null conversations keys.
1 participant
Summary
"perfectblend"as a registered prebaked dataset pointing tomlabonne/open-perfectblend, enablingoneshot(model, dataset="perfectblend"). Handles ShareGPT format conversion (from/value→role/content) and role mapping (human→user,gpt→assistant) automatically."ultrachat"as a convenience alias for the existing"ultrachat_200k"dataset.Test plan
"perfectblend","ultrachat", and"ultrachat_200k"correctlyoneshot(model, dataset="perfectblend", ...)end-to-end with a small modeloneshot(model, dataset="ultrachat", ...)end-to-end with a small model🤖 Generated with Claude Code