Skip to content

[Bugfix] Increase version requirement for skipped kv tests - #3056

Merged
kylesayrs merged 1 commit into
mainfrom
kylesayrs/bump-test-exclude-version
Aug 19, 2026
Merged

[Bugfix] Increase version requirement for skipped kv tests#3056
kylesayrs merged 1 commit into
mainfrom
kylesayrs/bump-test-exclude-version

Conversation

@kylesayrs

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c9c36bb3-6eec-4eb6-acb2-a28b5d10bf21

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 Merge protection satisfied — ready to merge.

Show 1 satisfied protection

🟢 Require one maintainer review

All PRs must have at least one approving review from a maintainer before merging.

  • #changes-requested-reviews-by = 0
  • any of:
    • approved-reviews-by=dsikka
    • approved-reviews-by=HDCharles
    • approved-reviews-by=brian-dellabetta
    • approved-reviews-by=kylesayrs
    • approved-reviews-by=yiliu30

@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the transformers version requirement in several test decorators from !=5.15.0 to >=5.16. Feedback from the reviewer indicates that since the transformers library is currently on version 4.x, setting the requirement to >=5.16 will inadvertently cause these tests to be skipped in CI. It is recommended to change the requirement to >=4.46 instead.

Comment thread tests/llmcompressor/transformers/kv_cache/test_kv_cache.py
Comment thread tests/llmcompressor/transformers/kv_cache/test_kv_cache.py
Comment thread tests/llmcompressor/transformers/kv_cache/test_kv_cache.py
Comment thread tests/llmcompressor/transformers/kv_cache/test_kv_cache.py
@kylesayrs
kylesayrs enabled auto-merge (squash) August 19, 2026 16:20
@kylesayrs kylesayrs added the ready When a PR is ready for full CI testing before merge label Aug 19, 2026
@kylesayrs
kylesayrs merged commit fe3c3ea into main Aug 19, 2026
9 checks passed
@kylesayrs
kylesayrs deleted the kylesayrs/bump-test-exclude-version branch August 19, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for full CI testing before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants