Skip to content

Add e2e sanity prompts to tiny model finetune dataset - #3047

Merged
dsikka merged 2 commits into
mainfrom
add-e2e-sanity-prompts-to-finetune-dataset
Aug 18, 2026
Merged

Add e2e sanity prompts to tiny model finetune dataset#3047
dsikka merged 2 commits into
mainfrom
add-e2e-sanity-prompts-to-finetune-dataset

Conversation

@kylesayrs

@kylesayrs kylesayrs commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds the three e2e vLLM sanity check prompts/answers to the copypasta finetune dataset in the create-tiny-model skill
  • Ensures tiny models learn correct answers for: "The capital of France is" → Paris, "The creator of the theory of relativity was Albert" → Einstein, "The classic game is called rock, paper," → scissors
  • Prompts sourced from tests/e2e/test_vllm.py SANITY_PROMPTS

🤖 Generated with Claude Code

Ensures tiny models learn the correct answers for the e2e vLLM sanity
checks (capital of France, theory of relativity, rock paper scissors).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7b8dfde4-2827-4fab-b873-ffe4baab33d3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the fine-tuning script .claude/skills/create-tiny-model/scripts/finetune.py by adding three new sanity check answers to the dataset list, aligning with the end-to-end sanity prompts in tests/e2e/test_vllm.py. There are no review comments, and I have no feedback to provide.

@mergify

mergify Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 Merge protection satisfied — ready to merge.

Show 1 satisfied protection

🟢 Require one maintainer review

All PRs must have at least one approving review from a maintainer before merging.

  • #changes-requested-reviews-by = 0
  • any of:
    • approved-reviews-by=dsikka
    • approved-reviews-by=HDCharles
    • approved-reviews-by=brian-dellabetta
    • approved-reviews-by=kylesayrs
    • approved-reviews-by=yiliu30

@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@kylesayrs kylesayrs added the ready When a PR is ready for full CI testing before merge label Aug 18, 2026
@dsikka
dsikka enabled auto-merge (squash) August 18, 2026 03:19
@dsikka
dsikka merged commit 6a6fa09 into main Aug 18, 2026
8 checks passed
@dsikka
dsikka deleted the add-e2e-sanity-prompts-to-finetune-dataset branch August 18, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for full CI testing before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants