Skip to content

[TEST] No-trigger test: tests/e2e/ change #3008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rashmigottipati wants to merge 7 commits into
base: main
Choose a base branch
from
+50 −42
Open

[TEST] No-trigger test: tests/e2e/ change #3008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2aa3c01
Simplify Transformers tests detection using Buildkite if_changed
rashmigottipati Jul 30, 2026
e256fe8
address review comments
rashmigottipati Aug 6, 2026
ea23b1b
Switch if_changed to use include/exclude attributes
rashmigottipati Aug 7, 2026
f43598c
Limit branch transformers tests to main branch only
rashmigottipati Aug 10, 2026
7ecdb81
make the if condition also match release-* branches using Buildkite's…
rashmigottipati Aug 12, 2026
bcbccb3
Test: Change tests/e2e/ file (should NOT trigger transformers tests)
rashmigottipati Aug 7, 2026
3799e7d
Merge branch 'main' into test-no-trigger-e2e-change
rashmigottipati Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 24 additions & 21 deletions .buildkite/gpu-tests/gpu-tests-H100.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,27 +85,30 @@ steps:
chmod +x .buildkite/gpu-tests/scripts/combine-coverage.sh
.buildkite/gpu-tests/scripts/combine-coverage.sh

- label: ":mag: Detect changes for Transformers Tests"
# Transformers tests - run on main and release branch pushes
- label: ":mag: Transformers Tests (branch)"
if: build.pull_request.id == null && (build.branch == "main" || build.branch =~ /^release-/)
agents:
queue: RedHat-ModelOpt-Util
command: |
if [ "$${BUILDKITE_PULL_REQUEST}" = "false" ]; then
echo "Push to branch — uploading transformers tests"
buildkite-agent pipeline upload .buildkite/gpu-tests/transformers-tests-H100.yml
else
git fetch --unshallow 2>/dev/null || true
git fetch origin "$${BUILDKITE_PULL_REQUEST_BASE_BRANCH}"
DIFF_FILES=$$(git diff --name-only "origin/$${BUILDKITE_PULL_REQUEST_BASE_BRANCH}...HEAD")
CHANGED=$$(echo "$${DIFF_FILES}" \
| grep -E '^(src/|tests/|setup\.py$$|MANIFEST\.in$$|\.buildkite/gpu-tests/transformers-tests-|\.buildkite/gpu-tests/scripts/run-tests\.sh$$)' \
| grep -vE '^tests/(e2e|lmeval|examples)/' \
| grep -vE '\.md$$' \
|| true)
if [ -n "$${CHANGED}" ]; then
echo "Relevant changes detected:"
echo "$${CHANGED}"
buildkite-agent pipeline upload .buildkite/gpu-tests/transformers-tests-H100.yml
else
echo "No relevant changes — skipping transformers tests"
fi
fi
buildkite-agent pipeline upload .buildkite/gpu-tests/transformers-tests-H100.yml

# Transformers tests - conditional on PRs when relevant paths changed
- label: ":mag: Transformers Tests (PR)"
if: build.pull_request.id != null
agents:
queue: RedHat-ModelOpt-Util
if_changed:
include:
- "src/**"
- "tests/**"
- "setup.py"
- "MANIFEST.in"
- ".buildkite/gpu-tests/**"
exclude:
- "tests/e2e/**"
- "tests/lmeval/**"
- "tests/examples/**"
- "**/*.md"
command: |
buildkite-agent pipeline upload .buildkite/gpu-tests/transformers-tests-H100.yml
45 changes: 24 additions & 21 deletions .buildkite/gpu-tests/gpu-tests-L4.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,27 +74,30 @@ steps:
chmod +x .buildkite/gpu-tests/scripts/combine-coverage.sh
.buildkite/gpu-tests/scripts/combine-coverage.sh

- label: ":mag: Detect changes for Transformers Tests"
# Transformers tests - run on main and release branch pushes
- label: ":mag: Transformers Tests (branch)"
if: build.pull_request.id == null && (build.branch == "main" || build.branch =~ /^release-/)
agents:
queue: RedHat-ModelOpt-Util
command: |
if [ "$${BUILDKITE_PULL_REQUEST}" = "false" ]; then
echo "Push to branch — uploading transformers tests"
buildkite-agent pipeline upload .buildkite/gpu-tests/transformers-tests-L4.yml
else
git fetch --unshallow 2>/dev/null || true
git fetch origin "$${BUILDKITE_PULL_REQUEST_BASE_BRANCH}"
DIFF_FILES=$$(git diff --name-only "origin/$${BUILDKITE_PULL_REQUEST_BASE_BRANCH}...HEAD")
CHANGED=$$(echo "$${DIFF_FILES}" \
| grep -E '^(src/|tests/|setup\.py$$|MANIFEST\.in$$|\.buildkite/gpu-tests/transformers-tests-|\.buildkite/gpu-tests/scripts/run-tests\.sh$$)' \
| grep -vE '^tests/(e2e|lmeval|examples)/' \
| grep -vE '\.md$$' \
|| true)
if [ -n "$${CHANGED}" ]; then
echo "Relevant changes detected:"
echo "$${CHANGED}"
buildkite-agent pipeline upload .buildkite/gpu-tests/transformers-tests-L4.yml
else
echo "No relevant changes — skipping transformers tests"
fi
fi
buildkite-agent pipeline upload .buildkite/gpu-tests/transformers-tests-L4.yml

# Transformers tests - conditional on PRs when relevant paths changed
- label: ":mag: Transformers Tests (PR)"
if: build.pull_request.id != null
agents:
queue: RedHat-ModelOpt-Util
if_changed:
include:
- "src/**"
- "tests/**"
- "setup.py"
- "MANIFEST.in"
- ".buildkite/gpu-tests/**"
exclude:
- "tests/e2e/**"
- "tests/lmeval/**"
- "tests/examples/**"
- "**/*.md"
command: |
buildkite-agent pipeline upload .buildkite/gpu-tests/transformers-tests-L4.yml
2 changes: 2 additions & 0 deletions tests/e2e/test_vllm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
import re
import shutil
import sys

# Test change: This should NOT trigger transformers tests (e2e excluded)
import time
from pathlib import Path
from typing import NamedTuple
Expand Down
Loading