Skip to content

[CI][AMD] Add opt-in Hugging Face Hub retries#429

Draft
AndreasKaratzas wants to merge 1 commit into
mainfrom
akaratza_hf_hub_offline_ci
Draft

[CI][AMD] Add opt-in Hugging Face Hub retries#429
AndreasKaratzas wants to merge 1 commit into
mainfrom
akaratza_hf_hub_offline_ci

Conversation

@AndreasKaratzas

@AndreasKaratzas AndreasKaratzas commented Jul 22, 2026

Copy link
Copy Markdown
Member

Summary

Cached CI jobs should not contact Hugging Face Hub unless the cache is missing something. This change makes the AMD policy opt-in through VLLM_CI_HF_HUB_MODE. When the variable is unset or empty, both pipeline generators preserve the existing step environment and retry policy.

Using the Hub cache in online mode still performs metadata checks, which creates unnecessary traffic and exposes otherwise healthy jobs to rate limits and network timeouts. This PR supports an opt-in AMD rollout in both pipeline generators:

  • Pass VLLM_CI_HF_HUB_MODE only to wrapped AMD test steps when it is explicitly enabled. Nightly and PyTorch-nightly builds promote an enabled mode to online.
  • Retry exit status 75 once. The companion vLLM runner emits that status only for an offline cache miss or a transient Hub failure.
  • Apply the same policy in the legacy MiniJinja template and the Python generator, including direct AMD-device steps and AMD mirrors.
  • Leave the generated data unchanged when the gate is absent, including direct no_plugin commands, AMD infrastructure steps, the existing AMD_RETRY policy, and native source gating.

The error classification and request statistics live in vLLM; ci-infra only selects the mode and configures the Buildkite retry. Companion vLLM PR: vllm-project/vllm#49401.

Testing

  • pytest -q buildkite/tests — 54 passed.
  • pytest -q buildkite/tests/test_amd_template_render.py — 8 passed with MiniJinja 2.3.1.
  • ruff check buildkite/pipeline_generator/amd.py buildkite/pipeline_generator/buildkite_step.py buildkite/tests/pipeline_generator/test_amd.py buildkite/tests/test_amd_template_render.py — passed.
  • git diff --check — passed.

Signed-off-by: Andreas Karatzas <akaratza@amd.com>
@AndreasKaratzas
AndreasKaratzas force-pushed the akaratza_hf_hub_offline_ci branch from e87cac4 to a20f748 Compare July 22, 2026 21:58
@AndreasKaratzas AndreasKaratzas changed the title [CI][AMD] Enable offline-first Hugging Face Hub retries [CI][AMD] Add opt-in Hugging Face Hub retries Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant