Skip to content

Fix parsing for rooms starting with # #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FredeJ wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix parsing for rooms starting with # #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8bc50e
Add address to test which currently fails.
FredeJ Dec 13, 2021
f0c3d42
Expand parsing to capture roomnumbers starting with \#.
FredeJ Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyap/source_US/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ def street_type_list_to_regex(street_type_list):
)
|
(?:
\#[0-9]{,3}[A-Za-z]{1}
\#[0-9]{0,4}[A-Za-z]{0,1}
)
)\ ?
)
Expand Down
5 changes: 5 additions & 0 deletions test_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,8 @@ def test_parse_address():
addresses = ap.parse(test_address)
assert addresses[0].full_address == \
"225 E. John Carpenter Freeway, Suite 1500 Irving, Texas 75062"

test_address2 = "225 E. John Carpenter Freeway, #1500 Irving, Texas 75062"
addresses2 = ap.parse(test_address2)
assert addresses2[0].full_address == \
"225 E. John Carpenter Freeway, #1500 Irving, Texas 75062"