Prod: adopt v0.1.79, swoosh v0.1.11 - #248
Merged
Merged
Conversation
Ships the ref-mode work (#247). The dashboard half is already live — Netlify deploys from main on merge — so production is currently serving an Ad Attributions step whose endpoint adopt v0.1.78 does not have, and an extraction form offering `variable` + `ad_table_lookup`, which v0.1.78 rejects at save. This closes that gap. Both images are inert against production data, verified against vprod rather than assumed: 0 of 719 destination confs carry ref_mode or include_metadata_in_ref, so all 719 resolve to "metadata" and creatives stay byte-identical — vlab-adopt-ads should generate zero instructions on its next run. 0 of 691 inference confs declare a mapping, so no event produces an ad outcome, exactly as today. No migration: this change adds no SQL, and ad_attributions plus its ref_token column are already live at 20260818000000. migrations stays v0.2.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for vlab-dashboard canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ships #247. The dashboard half is already live — Netlify deploys from main on
merge — so production is currently serving an Ad Attributions step whose
endpoint adopt v0.1.78 does not have, and an extraction form offering
variable+ad_table_lookup, which v0.1.78 rejects at save. This closes thatgap.
versionAdopt(vlab-conf-dashboard+ 4 CronJobs)swooshCronJobmigrationsInert against production data
Verified against vprod rather than assumed:
ref_mode/include_metadata_in_ref/"shortcode"mapping/ad_table_lookup/location: "ad"All 719 destinations resolve to
"metadata", so creatives stay byte-identical(
test_messenger_creatives_are_byte_identical_when_the_mode_is_unset) andvlab-adopt-adsshould generate zero instructions. With no lookup confsanywhere,
adAttributionOutcomereturns nil for every event exactly as today.The check after apply
vlab-adopt-adsruns30 */2 * * *. Its first run after this should producezero instructions — that is the byte-identical claim meeting reality.
swooshruns
30 * * * *and should show no newad=unmappedevents.Rollback is a revert of this commit plus
helm upgrade; both prior imagesremain in ghcr.
🤖 Generated with Claude Code