chore(prod): dinersclub v0.0.46 - #153
Merged
Merged
Conversation
Staging has run v0.0.46 since helm rev 81 with zero restarts, a healthy scrape target, and two real Reloadly payments through it: one success, one COULD_NOT_AUTO_DETECT_OPERATOR classified permanent and delivered to the respondent exactly as before. No unclassified codes, no processing faults. Verified before applying: main's production.yaml already matched live vprod on every one of the 27 gbv-owned workloads, so this upgrade changes exactly one image and adds no new workload. That was the failure mode PR #147 was written about -- a version sitting ahead of the cluster becomes a silent passenger on the next unrelated `helm upgrade`. PR #147 itself is stale and should be closed rather than merged: it pins dinersclub back to v0.0.43-wa on the grounds that v0.0.45 switches DingConnect to Generic Secrets, but v0.0.45 has since been deployed on its own, and the v0.0.45..v0.0.46 range does not touch dingconnect.go at all. dingconnect is also absent from DINERSCLUB_PROVIDERS in both environments. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016w2xUDzsqh6VJei1UgmgPg
✅ Deploy Preview for vlab-research canceled.
|
✅ Deploy Preview for virtuallab-videos canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes #151 / #152 to production. Staging has run
v0.0.46since helm rev 81.Staging evidence
serviceMonitor/vstag/gbv-dinersclub/0— up, no errorCOULD_NOT_AUTO_DETECT_OPERATOR(classifiedpermanent, delivered to the respondent as before)Blast radius: one image
Checked main's
production.yamlagainst all 27gbv-owned workloads invprodbefore bumping — already identical. So:and nothing else; no new workloads. That silent-passenger problem is exactly what PR #147 was written about.
PR #147 should be closed, not merged
It pins dinersclub back to
v0.0.43-wabecausev0.0.45moves DingConnect to Generic Secrets. That's stale:v0.0.45has since been deployed on its own, thev0.0.45..v0.0.46range doesn't touchdingconnect.go, anddingconnectisn't inDINERSCLUB_PROVIDERSin either environment.Alert rules land after this
vlab-alertsis deployed after the image, becauseDinersClubMetricsMissingis legitimately true until prod is scraped. That deploy is purely additive — verifiedpayment-healthis the only rule added, with none changed or removed.🤖 Generated with Claude Code
https://claude.ai/code/session_016w2xUDzsqh6VJei1UgmgPg